Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Crucible PHD tests in CI #273

Closed
gjcolombo opened this issue Dec 14, 2022 · 1 comment
Closed

Enable Crucible PHD tests in CI #273

gjcolombo opened this issue Dec 14, 2022 · 1 comment
Labels
enhancement New feature or request. storage Related to storage devices/backends. testing Related to testing and/or the PHD test framework.
Milestone
Unscheduled

Comments

@gjcolombo
Copy link
Contributor

To run Crucible tests, PHD needs the path to a local crucible-downstairs binary that was built at the same commit as PHD's/Propolis's crucible-client-types dependency.

Crucible's build-release buildomat job publishes an archive (crucible-nightly.tar.gz) that contains the downstairs binary (among other things), so is probably just a matter of finding the most appropriate way to pull that down in phd-run.sh.
@gjcolombo gjcolombo added enhancement New feature or request. storage Related to storage devices/backends. testing Related to testing and/or the PHD test framework. labels Dec 14, 2022
@gjcolombo gjcolombo added this to the Unscheduled milestone Apr 6, 2023
@gjcolombo
Copy link
Contributor Author

This was fixed by #604.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request. storage Related to storage devices/backends. testing Related to testing and/or the PHD test framework.
Projects
None yet
Milestone
Unscheduled
Development

No branches or pull requests
1 participant
@gjcolombo