Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should support naming the metric in OxQL queries, in addition to the special datum identifier #6761

Open
bnaecker opened this issue Oct 2, 2024 · 0 comments
Labels
oxql Oximeter Query Langauge

Comments

@bnaecker
Copy link
Collaborator

bnaecker commented Oct 2, 2024

Today, one can write OxQL queries like get foo:bar | datum > 100, where datum is a "special identifier" that we cons up to mean "the value at each point in the resulting timeseries". This behavior is implicit, which isn't great, and also falls over the moment we do joins: which element of the resulting multi-dimensional value does that refer to? We currently say, "neither" and return an error.

We could instead let folks write an identifier that is the metric name itself. From the above example, that'd be get foo:bar | bar > 100. If we join multiple tables together, then you can still refer to each one separately in your query, assuming they have different names. We could also consider "fully-qualified" syntax like { get foo:bar; get baz:quux } | align mean_within(1h) | filter foo:bar > 100, which would let us completely disambiguate which one the filter should apply to.

@bnaecker bnaecker added the oxql Oximeter Query Langauge label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oxql Oximeter Query Langauge
Projects
None yet
Development

No branches or pull requests

1 participant