New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve instance hostname validation #4301

Open

iliana opened this issue Oct 19, 2023 · 0 comments

Assignees

Contributor

iliana commented Oct 19, 2023 •

edited

Loading

That was the intent. In RFD 4 names were defined to be compliant with RFC 1035. However, I don't think we ever validated hostname the same way:

omicron/common/src/api/internal/nexus.rs

Lines 38 to 40 in 463cc1a

    
               /// RFC1035-compliant hostname for the instance. 
        
               // TODO-cleanup different type? 
        
               pub hostname: String,

Originally posted by @davepacheco in #4265 (comment)

iliana self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment