Tracking Issue for Database Improvements

[smklein]

Tracking issue for improvements interacting with the database. Please edit and add issues accordingly.

Async

• Upgrade to diesel-async? #4188

Pools

• Revisit decision to use "bb8" as a connection pool? #4192
• Clean connections that are returned to connection pool #4191

Transactions & CTEs

• Nexus should retry all transactions CRDB tells it to #3814
• CRDB returned "RETRY_SERIALIZABLE - failed preemptive refresh due to a conflict" when creating 3 instances concurrently #3304
• Consider upstreaming CTE support #4190
• crash-correctness issues related to not using transactions well #973

Updates

• [diesel] CTE should reference columns explicitly #210
• (Related to [diesel] CTE should reference columns explicitly #210) Audit usage of SELECT * and RETURNING *, prefer explicit columns so we access columns consistently across updates

Safety

• Audit all use of push_sql + format! within nexus/db-queries to prevent SQL Injection #4144
• [db] Audit usage of "ON CONFLICT DO NOTHING RETURNING ..."  #1168
• how does diesel report network errors during a query? #263

Ergonomics

• use CockroachDB enums in more places in database schema #312