-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_util: Add meaningful names to test LogContexts #900
Comments
Hmm. When this was created, the intent was to put the actual test name there. In practice, it's quite often not that anyway because:
I'm wondering if we should just treat this as an "arbitrary caller-provided label", which is really what it is anyway. Then change the callers to provide better names. Related but tangential: we've long wanted a What do folks think? |
Currently, when a test creates a new
LogContext
, a numeric counter is incremented every time a test creates a newLogContext
, and the resultant path will be of the form{test_name}.{pid}.{id}.log
. The counter is useful as it ensures that multipleLogContext
s can coexist within a single test execution. However, it doesn't really help with identifying what entity in the test created that log file. Instead, this must be inferred by reading the test code to determine the order in whichLogContext
s are created, which can sometimes be challenging --- especially when there's a bunch of test support code spinning up multiple Dropshot servers.It would be nice if there was a way to add a human-readable test component identifier to these log paths, like "server" or "client". The counter could still be used in addition to such an additional identifier to ensure all paths are unique.
The text was updated successfully, but these errors were encountered: