From 57ab1bd0587773fd1217e5242d201d236a7d6823 Mon Sep 17 00:00:00 2001
From: Matt Keeter <matt@oxide.computer>
Date: Thu, 10 Oct 2024 10:56:04 -0400
Subject: [PATCH] Minor cleanups to print_last_completed

---
 upstairs/src/downstairs.rs | 5 +----
 upstairs/src/guest.rs      | 1 -
 upstairs/src/upstairs.rs   | 1 +
 3 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/upstairs/src/downstairs.rs b/upstairs/src/downstairs.rs
index b69c7ec0c..205588e4b 100644
--- a/upstairs/src/downstairs.rs
+++ b/upstairs/src/downstairs.rs
@@ -2756,10 +2756,7 @@ impl Downstairs {
 
     /// Prints the last `n` completed jobs to `stdout`
     pub(crate) fn print_last_completed(&self, n: usize) {
-        // TODO this is a ringbuffer, why are we turning it to a Vec to look at
-        // the last five items?
-        let done = self.completed.to_vec();
-        for j in done.iter().rev().take(n) {
+        for j in self.completed.iter().rev().take(n) {
             print!(" {:4}", j);
         }
     }
diff --git a/upstairs/src/guest.rs b/upstairs/src/guest.rs
index f4cddc8a7..e01aee223 100644
--- a/upstairs/src/guest.rs
+++ b/upstairs/src/guest.rs
@@ -205,7 +205,6 @@ impl GuestWork {
     }
 
     pub fn print_last_completed(&self, n: usize) {
-        print!("Upstairs last five completed:  ");
         for j in self.completed.iter().rev().take(n) {
             print!(" {:4}", j);
         }
diff --git a/upstairs/src/upstairs.rs b/upstairs/src/upstairs.rs
index 93c5498e6..a28c685bc 100644
--- a/upstairs/src/upstairs.rs
+++ b/upstairs/src/upstairs.rs
@@ -1171,6 +1171,7 @@ impl Upstairs {
             .filter(|c| c.state() == DsState::Active)
             .count();
 
+        print!("Upstairs last five completed:  ");
         self.guest.guest_work.print_last_completed(5);
         println!();