Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add assertions for ds_new/ds_active consistency #765

Open
bcantrill opened this issue May 30, 2023 · 0 comments · May be fixed by #768
Open

add assertions for ds_new/ds_active consistency #765

bcantrill opened this issue May 30, 2023 · 0 comments · May be fixed by #768
Assignees

Comments

@bcantrill
Copy link
Contributor

The introduction oif ds_new in #738 introduced a possibility for inconsistency with ds_active -- and adding assertions that they are consistent serves to highlight those spots in which transient inconsistencies are not, in fact, incorrect. (That is, where the structures are inconsistent, but where the inconsistency has no consequence.) As @jmpesp pointed out, it would be good to rectify all of this: assert that these two structures are consistent, address those conditions in which they are inconsistent by implementation, and verify that those assertions do not diminish performance, See #738 (review) for additional details.

@jmpesp jmpesp self-assigned this May 31, 2023
jmpesp added a commit to jmpesp/crucible that referenced this issue Jun 1, 2023
Assert that the cached job ids in ds_new match the New jobs in
ds_active, and that io_state_count is correct.

Fixes oxidecomputer#765
jmpesp added a commit to jmpesp/crucible that referenced this issue Jun 1, 2023
Assert that the cached job ids in ds_new match the New jobs in
ds_active, and that io_state_count is correct.

Fixes oxidecomputer#765
@jmpesp jmpesp linked a pull request Jun 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants