Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment in upstairs/src/client.rs #1590

Open
leftwo opened this issue Dec 24, 2024 · 1 comment
Open

Fix comment in upstairs/src/client.rs #1590

leftwo opened this issue Dec 24, 2024 · 1 comment

Comments

@leftwo
Copy link
Contributor

leftwo commented Dec 24, 2024

This comment:

        // downstairs should automatically call PromoteToActive when it reaches
        // the relevant state.

Downstairs don't call, they send a message.

@leftwo
Copy link
Contributor Author

leftwo commented Dec 24, 2024

Also,

Clear this Downstair's ..

The internet says:

Use an apostrophe + s for singular nouns (sea, sky), common nouns ending with s (tigress, mistress), and irregular plural nouns (women, children). Use only the apostrophe for proper nouns ending with s (Tess, Jesus, Texas) and regular plural nouns (cars, protestors).

I believe because the downstairs is being used as a name here, it becomes a proper noun.
So, it should be Downstairs'

This also opens the door to changing downstairs to Downstairs everywhere.
As well as upstairs to Upstairs. go get busy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant