Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If validate_hashes() fails, it should leave some breadcrumbs #1307

Open
leftwo opened this issue May 14, 2024 · 0 comments
Open

If validate_hashes() fails, it should leave some breadcrumbs #1307

leftwo opened this issue May 14, 2024 · 0 comments

Comments

@leftwo
Copy link
Contributor

leftwo commented May 14, 2024

In downstairs/src/region.rs, we validate_hashes().
If that validation fails, we should leave behind some breadcrumbs to help diagnose why
there is a validation failure.

                if computed_hash != ctx.hash {
                    error!(self.log, "Failed write hash validation");
                    // TODO: print out the extent and block where this failed!!
                    crucible_bail!(HashMismatch);
                }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant