Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number input styling #1072

Closed
paryhin opened this issue Jul 26, 2022 · 3 comments
Closed

Number input styling #1072

paryhin opened this issue Jul 26, 2022 · 3 comments
Assignees
Labels
Milestone

Comments

@paryhin
Copy link

paryhin commented Jul 26, 2022

image

Hey, the styling of this element looks off, and the arrows make it look like a dropdown component. We may want to use a regular input for now, or create a new component for this use case, something like:

CleanShot 2022-07-26 at 19 47 03@2x

@paryhin paryhin added the polish label Jul 26, 2022
@david-crespo
Copy link
Collaborator

We used to have this, more or less. Don't remember why I got rid of it, but it might be useful to whoever implements this to see how we did it. Or maybe not. We were using Styled Components, so you might turn to stone or your eyes might fall out of your head if you look at it.

#199
https://console-ui-sto-git-feature-174-increment-textfield-oxide-b9def3.vercel.app/?path=/story/components-forms-numberfield--with-state

#294
https://console-ui-storybook-git-number-field-alt-oxidecomputer.vercel.app/?path=/story/components-fields-number-field--with-state

@david-crespo david-crespo added this to the MVP+1 milestone Feb 8, 2023
@david-crespo
Copy link
Collaborator

MVP+1 because it's currently ugly but it works.

@david-crespo
Copy link
Collaborator

Done in #1582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants