Assertion failed

[calintat]

I started using clarabel in a project and managed to make the following assertion fail:

Clarabel.rs/src/qdldl/qdldl.rs

Line 741 in d1ca25d

debug_assert!(*p.iter().max().unwrap_or(&0) < x.len());

Unfortunately I don't have a test case to reproduce it, as I am generating the LP problems dynamically and they are massive.

[lovasoa]

Indeed, the line looks incorrect to me.

debug_assert!(*p.iter().max().unwrap_or(&0) < x.len());

If p and x are both empty, the unsafe block is a harmless no-op, but the assert reduces to 0 < 0 which is false.
The assert could be corrected as:

debug_assert!(p.is_empty() || *p.iter().max().unwrap() < x.len());

What do you think @goulart-paul ?

[goulart-paul]

Yes, I agree. Fixed in #138.

Apologies for the delay. I was overtaken by term time teaching and only coming back to fix things here now.