Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes clipping happens when reverb volume is on maximum #23

Open
Boscop opened this issue Mar 11, 2018 · 2 comments
Open

Sometimes clipping happens when reverb volume is on maximum #23

Boscop opened this issue Mar 11, 2018 · 2 comments

Comments

@Boscop
Copy link

Boscop commented Mar 11, 2018

When I put the reverb volume on maximum and play certain notes with certain patches (e.g. program 48: PercOrgan) the sound is clipping.
Maybe it makes sense to have a master volume knob or a simple internal compressor like sylenth? (or a tube waveshaper as soft knee limiter)

@djtuBIG-MaliceX
Copy link

See #16

@djtuBIG-MaliceX
Copy link

Raised PR #33 to address the bad distortion on max volume reverb.
It however does not address the internal clipping done by Oxe globally - there's some refactoring required to change its signal summation to use floating point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants