From 14d62984313369c9ca4a872daeca2700ef08a361 Mon Sep 17 00:00:00 2001 From: Swikriti Tripathi Date: Thu, 13 Jul 2023 14:03:34 +0545 Subject: [PATCH] Remove github comment from drone CI --- .drone.star | 39 +-------------------------------------- 1 file changed, 1 insertion(+), 38 deletions(-) diff --git a/.drone.star b/.drone.star index b795da8..dfc03be 100644 --- a/.drone.star +++ b/.drone.star @@ -21,7 +21,6 @@ PLUGINS_SLACK = "plugins/slack:1" SELENIUM_STANDALONE_CHROME_DEBUG = "selenium/standalone-chrome-debug:3.141.59-oxygen" SELENIUM_STANDALONE_FIREFOX_DEBUG = "selenium/standalone-firefox-debug:3.8.1" SONARSOURCE_SONAR_SCANNER_CLI = "sonarsource/sonar-scanner-cli" -THEGEEKLAB_DRONE_GITHUB_COMMENT = "thegeeklab/drone-github-comment:1" DEFAULT_PHP_VERSION = "7.4" DEFAULT_NODEJS_VERSION = "14" @@ -885,7 +884,6 @@ def acceptance(ctx): "skip": False, "debugSuites": [], "skipExceptParts": [], - "earlyFail": True, "enableApp": True, "selUserNeeded": False, } @@ -923,14 +921,6 @@ def acceptance(ctx): if params["skip"]: continue - # switch off earlyFail if the PR title contains full-ci - if ("full-ci" in ctx.build.title.lower()): - params["earlyFail"] = False - - # switch off earlyFail when running cron builds (for example, nightly CI) - if (ctx.build.event == "cron"): - params["earlyFail"] = False - if "externalScality" in params and len(params["externalScality"]) != 0: # We want to use an external scality server for this pipeline. # That uses some "standard" extraSetup and extraTeardown. @@ -1142,7 +1132,7 @@ def acceptance(ctx): "path": "%s/downloads" % dir["server"], }], }), - ] + testConfig["extraTeardown"] + githubComment(params["earlyFail"]), + ] + testConfig["extraTeardown"], "services": databaseService(testConfig["database"]) + browserService(testConfig["browser"]) + emailService(testConfig["emailNeeded"]) + @@ -1969,33 +1959,6 @@ def buildTestConfig(params): configs.append(config) return configs -def githubComment(earlyFail): - if (earlyFail): - return [{ - "name": "github-comment", - "image": THEGEEKLAB_DRONE_GITHUB_COMMENT, - "pull": "if-not-exists", - "settings": { - "message": ":boom: Acceptance tests pipeline ${DRONE_STAGE_NAME} failed. The build has been cancelled.\\n\\n${DRONE_BUILD_LINK}/${DRONE_JOB_NUMBER}${DRONE_STAGE_NUMBER}", - "key": "pr-${DRONE_PULL_REQUEST}", - "update": "true", - "api_key": { - "from_secret": "github_token", - }, - }, - "when": { - "status": [ - "failure", - ], - "event": [ - "pull_request", - ], - }, - }] - - else: - return [] - def checkStarlark(): return [{ "kind": "pipeline",