Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider invalidating sessions on 2fa setup #222

Open
C0rby opened this issue May 12, 2021 · 0 comments
Open

Consider invalidating sessions on 2fa setup #222

C0rby opened this issue May 12, 2021 · 0 comments

Comments

@C0rby
Copy link

C0rby commented May 12, 2021

Currently when a user enable 2fa all existing sessions are still valid. It seems to be considered best-practice to invalidate existing sessions when enabling 2fa.

This could be considered a hardening.

Keep in mind when invalidating sessions all clients need to reauthenticate including the mobile and desktop apps.
So it's a tradeoff between security and convenience.

Also in case of an account compromise the user SHOULD always change the password and also can manually invalidate specific sessions in the settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant