Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display banner on every page #13

Open
PVince81 opened this issue Sep 4, 2018 · 6 comments
Open

Display banner on every page #13

PVince81 opened this issue Sep 4, 2018 · 6 comments

Comments

@PVince81
Copy link
Contributor

PVince81 commented Sep 4, 2018

In case someone somehow is running daily-qa-stable10 or some version of it containing the testing app, as this is insecure, show a banner on every page.

Could either be a yellow notification or inject some flashy DOM element in the header.

@PVince81
Copy link
Contributor Author

PVince81 commented Sep 4, 2018

bonus point if it's animated

@patrickjahns
Copy link
Contributor

@PVince81

Not sure if this is a good path to go - as it alters the DOM and might cause issue with UI testing. :/

@VicDeo
Copy link
Member

VicDeo commented Sep 4, 2018

what about CSS 'content' rule?

@PVince81
Copy link
Contributor Author

PVince81 commented Sep 4, 2018

Not sure if this is a good path to go - as it alters the DOM and might cause issue with UI testing. :/

it might indeed. would need something unintrusive, hmmm...

@phil-davis
Copy link
Contributor

As in the comments above, it changes what we are testing in UI tests. Specially it might interfere with tests that deal with notifications or error messages or even main menu button navigation.

@PVince81
Copy link
Contributor Author

PVince81 commented Sep 5, 2018

you could also have a non-default setting that disables the banner

so if one would install the tarball, the banner is visible by default
then test suites will set the config switch "disable annoying banner=true" so it stops loading the matching JS file.

but maybe that's already going too far for a rather unlikely case.

feel free to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants