Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[For 10.1] Dropbox External Storage Release 1.1.0 #10

Closed
26 of 31 tasks
pmaier1 opened this issue Oct 2, 2017 · 16 comments
Closed
26 of 31 tasks

[For 10.1] Dropbox External Storage Release 1.1.0 #10

pmaier1 opened this issue Oct 2, 2017 · 16 comments
Assignees
Milestone

Comments

@pmaier1
Copy link
Contributor

pmaier1 commented Oct 2, 2017

App release template

When marking a task as done, please add your name to the task!

Reason

  • Ironing out migration and better integration with core

Open tasks

Still open from v1

  • IMPORTANT: write a migration that switches every oc_external_config entry that has the old Dropbox backend to the one from this app => users need to recreate and reauthorize the endpoint anyway, so not needed
  • get New Cacheable Flysystem Adapter core#29077 merged into core's master and stable10 for upcoming 10.0.4

Second version: after 10.0.4 release

QA

Documentation

  • Changes in the docs needed?

Marketing

  • Ping RocketChat channel #marketing
  • Check/adapt info.xml stuff
  • Check/adapt screenshot
  • Blog post or other communication if applicable

Build & Marketplace release

All actions to be done on the release branch from here:

  • Bump version in info.xml
  • Update CHANGELOG.md - Change CHANGELOG.md 'Unreleased' to '$version - $currentDate' (ex: 3.1.5 - 2018-08-01)
  • Create github tag for 'v${version}RC1'
  • Build and sign RC tarball from github tag 'v${version}RC1' with make dist => https://cloud.owncloud.com/index.php/s/ILlqjBvwsdTqcGW
  • Test and document in testplan => Final "Go" from QA (set 'QA-ready' label) => else do another RC after fixing
  • Create github tag for final 'v${version}'
  • Build and sign final tarball from github tag 'v${version}' with make dist
  • Smoke test tarball (at least install + enable)
  • Github release
  • Upload to marketplace
  • Publish for customers
  • Send mail to release-coordination with link to this ticket and to the changelog
  • Rename QA milestone to '$version'
  • Add a new 'Unreleased' section in CHANGELOG.md
  • Create PR to merge changes back to the master branch: Release 1.1.0 #50
@pmaier1 pmaier1 added the orga label Oct 2, 2017
@pmaier1 pmaier1 added this to the development milestone Oct 2, 2017
@pmaier1 pmaier1 self-assigned this Oct 2, 2017
@pmaier1 pmaier1 mentioned this issue Oct 2, 2017
12 tasks
@PVince81
Copy link
Contributor

PVince81 commented Oct 9, 2017

@Hemant-Mann do you have time to work on these ?

@Hemant-Mann
Copy link
Collaborator

Yes I am a little busy but if you could share the expected timeline for the release of v2 it would help to estimate the time required for the changes

@Hemant-Mann
Copy link
Collaborator

I think the only major task from the checklist is the Migration

@patrickjahns
Copy link
Contributor

I think we could push a v1.0.1 with at least the naming change on the marketplace? so it gets less confusing with two dropbox options

@Hemant-Mann
Copy link
Collaborator

Yes good idea

@PVince81
Copy link
Contributor

Added "Must work with PHP 5.6". We might want to do another release once this is in place and tested, without waiting for 10.0.4.

@Hemant-Mann
Copy link
Collaborator

Hemant-Mann commented Nov 5, 2017

Hey @PVince81
I was looking into Dropbox Webhooks API https://www.dropbox.com/developers/reference/webhooks
But it says that

The payload of the notification request does not include the actual file changes. It only informs your app of which users have changes.

You will typically want to call /files/list_folder/continue to get the latest changes for each user in the notification, keeping track of the latest cursor for each user as you go.

And we have only ten seconds to respond to webhook requests

The solutions mentioned on the website are a) Use threads b) Async Queues
Any Ideas how we can achieve the same in owncloud

@patrickjahns patrickjahns modified the milestones: QA, development Dec 1, 2017
@patrickjahns patrickjahns changed the title v2 Tasks for next major version (v2) Jan 10, 2018
@PVince81 PVince81 changed the title Tasks for next major version (v2) Dropbox External Storage Release 1.1.0 Jun 20, 2018
@PVince81 PVince81 self-assigned this Jun 22, 2018
@PVince81
Copy link
Contributor

PR for changelog to get a view of what has changed since 1.0.1: #38

we'll look into releasing the app as is

@Hemant-Mann would you have time to remove the flysystem adapter which you moved to core before we do so ? if not we'll leave the app as is, it's ok

@Hemant-Mann
Copy link
Collaborator

Hi @PVince81

to be honest it's been quite a time since I last worked on core so it might take some time to do that

@PVince81
Copy link
Contributor

@Hemant-Mann yes, I understand. The Dropbox app isn't high on the list of "to release" so this leaves a bit of time. If you don't have time to do it it's also ok.

@PVince81
Copy link
Contributor

PVince81 commented Nov 15, 2018

@PVince81
Copy link
Contributor

I've added "verify potential existing issues: #37" to confirm whether the lowercase issue and others are still happening. Tickets should be raised then.

@PVince81 PVince81 modified the milestones: development, QA Nov 23, 2018
@PVince81
Copy link
Contributor

raised #42 to address the "flysystem cache adapter" tech debt items. we'll release without that for now

@PVince81 PVince81 changed the title Dropbox External Storage Release 1.1.0 [For 10.1] Dropbox External Storage Release 1.1.0 Nov 29, 2018
@davitol
Copy link

davitol commented Nov 29, 2018

screen shot 2018-11-29 at 20 14 11

Using the tarball posted above and trying to install it in ownCloud 10.0.10

@PVince81
Copy link
Contributor

@davitol the tarball had two issues:

  • VCS files were included in signature but excluded later in tar
  • tar was truncating long path names resulting in missing file names during signature check...

all fixed in commit 9fa04e2

please retest with RC2 https://cloud.owncloud.com/index.php/s/KTwSnsPUmccpQpQ

@davitol
Copy link

davitol commented Dec 17, 2018

please retest with RC2 https://cloud.owncloud.com/index.php/s/KTwSnsPUmccpQpQ

@PVince81 Tarball is Qa-ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants