-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom groups should only be visible to members #93
Comments
I think we didn't purposefully "made them global". This is a side effect of using the sharing API integration and group backend API integration way. This is the first step anyway. If you want to have custom groups non-global and specific to members, you need to tick the sharing checkbox "Restrict users to only share with users in their groups" and it should work already. One trouble though is that the latter option is global to any group backend, not only the custom groups one. The idea we discussed before was to provide separate checkboxes, one for each group backend:
|
additional note: the splitting of checkboxes proposed previously is a change that needs to be done in core, as it's part of the sharing logic. |
@pmaier1 move to "planned" ? |
Moving to planned as discussed with @pmaier1. As soon as customgroups is released, rename "planned" to "development" |
We should give custom group admins some more flexiblity here by offering two options in regards of visibility: Public and Closed
|
p3 and triage, will need scheduling and assignment |
Not sure why we made custom groups global (every user can share with all groups of an instance).
Somehow I find it odd in the meantime as you get to see groups to share with in the sharing dialog that you actually don't 'know' and where you can't see the member list. The only use case I could think of is that I am advised to share with such a group while not getting all the other shares the group has.
If there are other use cases where the current handling is better, please shout out!
Addition TBD: We could change the default to 'not global' (only members can share with the group) and add an option (checkbox) to make it global.
The text was updated successfully, but these errors were encountered: