Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use group manager everywhere #91

Open
1 of 3 tasks
PVince81 opened this issue Aug 23, 2017 · 1 comment
Open
1 of 3 tasks

Use group manager everywhere #91

PVince81 opened this issue Aug 23, 2017 · 1 comment

Comments

@PVince81
Copy link
Contributor

PVince81 commented Aug 23, 2017

Goal is to be able to have the group manager events (hooks) triggered automatically:

The reason why we didn't do this in the first place back then was mostly because we didn't have the concept of "scope" before, so supporting the above operations would mean that the groups would become visible in the users page and provisioning API. Now that we have the scopes concept, this is not needed any more and we can now use the group manager instead.

To do so, the CustomGroupsDatabaseHandler must implement the above operations "officially" and advertise these through implementsAction. Then the DAV code needs to use the group manager's methods instead of going directly to the database handler. See delete PR for an example.

@PVince81
Copy link
Contributor Author

  • get rid of customgroups specific symfony events. The admin_audit app would just work with the regular group events, just need to make sure it's using the group id AND display name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant