Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Groups Release 0.6.1 #368

Closed
24 of 33 tasks
phil-davis opened this issue Sep 5, 2020 · 4 comments
Closed
24 of 33 tasks

Custom Groups Release 0.6.1 #368

phil-davis opened this issue Sep 5, 2020 · 4 comments
Labels
Milestone

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Sep 5, 2020

##Reason

PR #367 "[Security] Bump http-proxy from 1.16.2 to 1.18.1"

Does the security issue apply to the use in this repo?

If so, should a release be done?

(There seems to be not much else changed in master since 0.6.0 - just some translations and dependency version bumps)
Also #380 "[Security] Bump js-yaml from 3.10.0 to 3.14.1" - the same questions as above.

Product approval

  • Verify transifex commits are in master: If a folder https://github.com/owncloud//tree/master/l10n exists, then https://drone.owncloud.com/owncloud/ should receive nightly '[tx] updated from transifex` ...
  • Ping pmaier to check info.xml description and screenshot
  • Get approval on translations from pmaier - send the date of the last tx commit from drone to Patrick

QA

  • Generate Changelog
  • Create QA Milestone and set the description to $version
  • Move items from development to qa
  • Create release branch with the format "release-$version"
  • Create "$version Testplan" Custom Groups Release 0.6.1 #368 (comment)
  • copy new/reopened issues from the previous release ticket as 'Issues to review' below.

Documentation

  • Changes in the docs needed? If so create issue in owncloud/docs.

Marketing

  • Ping @owncloud/marketing

Build

All actions to be done on the release branch from here:

  • Bump version in info.xml (no version suffix)
  • Check php version dependency in info.xml
  • Check minimum ownCloud version dependency in info.xml
  • Change CHANGELOG.md 'Unreleased' to '$version' (today's date)

Beta/RC

  • Create github tag for v${version}RC1 on release branch
  • Build and sign RC tarball from github tag v${version}RC1 (see
    handbook for how to build)
  • Upload as Github release using changelog entries
  • Test and document in testplan => Final "Go" from QA (set 'QA-ready' label) => else do another RC after fixing issues in the "release-$version" branch

Final

  • Check that no documentation issues are pending
  • Rename last RC tarball to final
  • Create github tag for final v${version} on release branch
  • Upload as Github release using changelog entries
  • Ping #marketing channel to coordinate publishing

Publishing

  • Upload tarball to marketplace (see handbook in confluence for details)
  • Publish tarball for customers (see handbook in confluence for details) - https://customer.owncloud.com and https://portal.owncloud.com
  • Send mail to release-coordination with link to this ticket and to the changelog
  • Copy email to rocket chat #updates channel

Post-release

  • Rename QA milestone to $version
  • Add a new 'Unreleased' section in CHANGELOG.md (and also update links at the bottom!)
  • Create PR to merge changes back to the master branch with
    description "Closes #XYZ" with the release ticket number
  • Close the milestone
  • Ensure release template is up to date
@phil-davis
Copy link
Contributor Author

Also #380 "[Security] Bump js-yaml from 3.10.0 to 3.14.1" - the same questions as above.

@jnweiger
Copy link
Contributor

jnweiger commented Mar 4, 2021

Yes, that justifies a patch release. Queued.

@jnweiger jnweiger pinned this issue Mar 5, 2021
@jnweiger jnweiger added the orga label Mar 5, 2021
@jnweiger jnweiger added this to the QA milestone Mar 5, 2021
@GeraldLeikam
Copy link
Contributor

GeraldLeikam commented Mar 8, 2021

Test plan

  • Enable the app
    • No problems found
  • Disable and enable the app using CLI
    • No problems found
  • Create a custom group
    • Custom group is created correctly
  • Create an already existing custom group
    • The group cannot be created again
  • Delete a custom group
    • The group is removed correctly
  • Rename a custom group
    • The group is renamed correctly
  • As a non-admin member try to rename its custom group
    • He cannot rename its custom group
  • Get members of a group
    • Members are retrieved correctly
  • Check that the creator of a custom group becames admin automatically
    • No problems found
  • As a creator of a custom group add members
    • Members are added correctly
  • As non-admin member of a custom group try to add members
    • Non-admin member cannot add members
  • Check that all the UI elements are usable when browsing
    • chrome
    • firefox
    • edge (win10)
  • can custom groups have same name as normal groups
    • try custrom group named admin. Do users gain admin powers?
    • user does not get admin rights

@jnweiger
Copy link
Contributor

jnweiger commented Mar 9, 2021

issues opened while testing

@jnweiger jnweiger closed this as completed Apr 6, 2021
@DeepDiver1975 DeepDiver1975 unpinned this issue Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants