Model's all logs are deleted after v13.6.5 when Threshold is more 0

[giolaza]

PHP Version

8.1

Laravel Version

9.52.16

Package Version

13.6.7

Description

Default installation used.
On version 13.6.5 was working good, but after updating project to 13.6.7 logs stopped. Downgrade helped

Steps To Reproduce

Basic install.
Use 13.6.5 - all is good
Use 13.6.7 - no logs

Possible Solutions

No response

[willpower232]

are you able to try 13.6.6 as well? are you able to share your config file?

[giolaza]

checked 13.6.6 same problem
config file - audit.php is not published (default used)

additionally i see: log created for model in 13.6.5 is deleted for some reason

[willpower232]

As per #947 this behaviour happens when the audit.threshold value is higher than 0. Is your code definitely not changing that one value at any point even if the config file isn't used? Can you output the value from php artisan tinker to confirm what it is?

[giolaza]

[giolaza]

found issue in
vendor/owen-it/laravel-auditing/src/Drivers/Database.php
here is db log:
\Illuminate\Support\Facades\DB::enableQueryLog(); $model->audits() ->latest() ->offset($threshold)->limit(PHP_INT_MAX) ->delete() > 0; $queries = \Illuminate\Support\Facades\DB::getQueryLog(); dd($queries);
delete from auditswhereaudits.auditable_type= ? andaudits.auditable_id= ? andaudits.auditable_idis not null order bycreated_at desc limit 9223372036854775807

delete method is ignoring offset method. this is reason why logs are removing("not creating")

[giolaza]

#951

[parallels999]

If audit.threshold = 0, that delete should never be executed

laravel-auditing/src/Drivers/Database.php

Line 25 in 22682dd

if (($threshold = $model->getAuditThreshold()) > 0) {

unless you have the auditThreshold property on that model, on that case, this would be a duplicate of #947

laravel-auditing/src/Auditable.php

Lines 616 to 619 in 22682dd

	public function getAuditThreshold(): int
	{
	return $this->auditThreshold ?? Config::get('audit.threshold', 0);
	}

[giolaza]

checked, forgot that in model I set limit for rows 1000000

[erikn69]

Hi, test new changes on #948