Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path of the Venom binary in the container image is unusual #811

Open
elchenberg opened this issue Aug 29, 2024 · 0 comments · May be fixed by #813
Open

path of the Venom binary in the container image is unusual #811

elchenberg opened this issue Aug 29, 2024 · 0 comments · May be fixed by #813

Comments

@elchenberg
Copy link

elchenberg commented Aug 29, 2024

In the container image docker.io/ovhcom/venom:v1.2.0 the path of Venom binary is /usr/local/venom.

The directory /usr/local is not in the PATH (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin).

This means that I need to look up (because I am forgetful) and use the full path to the binary if I want to run commands inside a Venom container that is already running (eg. docker run --entrypoint sh -it docker.io/ovhcom/venom:v1.2.0). I am also using the Venom image in GitLab CI and have to use the full path there, too, because the GitLab Runner starts the container with a shell and uses the shell to run Venom.

Although this is only a little inconvenience it would be nice if the binary could be placed at /usr/local/bin/venom instead so that I do not need to use the full path anymore.

-COPY dist/venom.linux-amd64 /usr/local/venom
+COPY dist/venom.linux-amd64 /usr/local/bin/venom

 VOLUME /workdir/results
 VOLUME /workdir/tests
 WORKDIR /workdir

-ENTRYPOINT ["/usr/local/venom"]
+ENTRYPOINT ["/usr/local/bin/venom"]

COPY dist/venom.linux-amd64 /usr/local/venom

09bassOp added a commit to 09bassOp/venom that referenced this issue Sep 2, 2024
Signed-off-by: Ivan Velasco <[email protected]>
09bassOp added a commit to 09bassOp/venom that referenced this issue Sep 2, 2024
Signed-off-by: Ivan Velasco <[email protected]>

Signed-off-by: Ivan Velasco <[email protected]>
@09bassOp 09bassOp linked a pull request Sep 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant