Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getOutgoingMessages() parameters name are not correct #26

Open
3ffusi0on opened this issue Feb 13, 2019 · 0 comments
Open

getOutgoingMessages() parameters name are not correct #26

3ffusi0on opened this issue Feb 13, 2019 · 0 comments

Comments

@3ffusi0on
Copy link

According to comments and body of the method, $startDateTime is used instead of $dateStart as well as $endDateTime instead of $dateEnd.

Using the current version result in notice :

Notice: Undefined variable: startDateTime in C:\Users\Pierre-Alain\Dev\api-v2\vendor\ovh\php-ovh-sms\src\SmsApi.php on line 400

Notice: Undefined variable: endDateTime in C:\Users\Pierre-Alain\Dev\api-v2\vendor\ovh\php-ovh-sms\src\SmsApi.php on line 408
3ffusi0on added a commit to 3ffusi0on/php-ovh-sms that referenced this issue Feb 13, 2019
@3ffusi0on
Fixes ovh#26 getOutgoingMessages parameters name
47ffbc6 
To be in concordance with comments and method body
vaga added a commit to plussimple/php-ovh-sms that referenced this issue Feb 22, 2019
@vaga
Merge pull request #1 from 3ffusi0on/master
45022ab 
Fixes ovh#26 getOutgoingMessages parameters name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@3ffusi0on