Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PNG optimizer with pillow #2068

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement PNG optimizer with pillow #2068

wants to merge 3 commits into from

Commits on Sep 27, 2022

  1. Implement PNG optimizer with pillow 

    Currently all Image optmizers will fork/exec on an external program for
every single image tile generated from dispatcher. This drags the
performance in the optimizing phase due to expensive user/kernel space
switching.

Using PIL/pillow allows image operations without launching external
programs. Hopefully this is an acceptable tradeoff between performance
and resulting file size.
    @cthbleachbit
    cthbleachbit committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    ffcedfa View commit details
    Browse the repository at this point in the history

  2. pillow png optimizer: use sane default options, 256 color + dithering

    @cthbleachbit
    cthbleachbit committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    6e0a02e View commit details
    Browse the repository at this point in the history

  3. pillow png optimizer: import PIL file-wide 

    For some reason PIL is not part of requirements.txt, but seems to be
assumed to exist in other parts of Overviewer. Programmatically imported
modules cannot be pickled and thus fails under multiprocessing, so we
are taking the assumption and import PIL early.
    @cthbleachbit
    cthbleachbit committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    52170a1 View commit details
    Browse the repository at this point in the history