Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read models and add 1.19 blocks that can't be dynamically rendered yet #2054

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

lieuwestra
Copy link

@lieuwestra lieuwestra commented Jul 10, 2022

Stable as far as I'm concerned. If you want 1.19 blocks you can safely use this.

  • Seems to be slightly slower than before.

What I'm not going to deal with for now

  • read blockstate files
  • apply uv
  • apply rotation value
  • setback of 'east' and 'south' faces since they are only relevant in exceptional circumstances

@lieuwestra lieuwestra changed the title Read models Read models and add 1.19 blocks that can't be dynamically rendered yet Jul 18, 2022
@lieuwestra lieuwestra marked this pull request as ready for review July 18, 2022 14:33
@lieuwestra
Copy link
Author

Should be good enough for rendering most blocks in future minecraft releases without the need to explicitly implement them. Not really sure how it behaves on different OSes.

@lieuwestra
Copy link
Author

There still seem to be problems with northdirection upper-right and lower-left. Working on it.

@EnBi81
Copy link

EnBi81 commented Dec 11, 2022

Hey @lieuwestra , any news about the 1.19?


return self.models[modelname]

def build_block_from_model(self, modelname, blockstate={}):
Copy link

@spjwebster spjwebster May 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI there's a recursion error creating textures for worlds created after 1.19.3 that's being caused by the new experimental chiseled bookshelf models added for 1.20.

I haven't had time to look into this more deeply, but for now this suggestion will skip building the problematic models:

Suggested change
def build_block_from_model(self, modelname, blockstate={}):
def build_block_from_model(self, modelname, blockstate={}):
if 'chiseled_bookshelf' in modelname:
return

@bagobones
Copy link

FYI from the projects main read me.

PLEASE NOTE: Overviewer is currently unmaintained. PRs will not be merged and issues will not be addressed. The website and repository will remain online and accessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants