Update the default color list used for the Biome Overlay. #1972
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the old, only partially complete and illogical default scheme, we now use the same one as Amidst.
The old default color scheme only contained a fraction of the available biomes, it seems it hasn't been updated for newer minecraft versions in ages. At first I tried to fill in the gaps by selecting colors myself to match the existing ones, but I was soon pulling my hair out, because there seemed to be no logic in these color choices. So instead, I threw it all away and just used the color scheme from the Amidst project that they describe in https://github.com/toolbox4minecraft/amidst/wiki/Biome-Color-Table . That scheme does seem to have a certain logic (e.g. the colors of similar biomes are similar), and it also seems to be sort of a de facto standard - e.g. the chunkbase seedmap uses it too.
While no code was directly copied, so IMHO their GPL3 license does not apply, I only found it fair to give them credit - which I did in both the source code and the documentation.