Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite more readable #32

Open
oliversalzburg opened this issue Mar 22, 2018 · 0 comments
Open

Rewrite more readable #32

oliversalzburg opened this issue Mar 22, 2018 · 0 comments

Comments

@oliversalzburg
Copy link

I hope you don't take this the wrong way, but the existing code is horrible. It is extremely hard to read and understand, mostly thanks to the choice of cryptic variable names where the purpose is undocumented.

I took my best shot with this approach: https://gist.github.com/oliversalzburg/99a755a8fc0b0e52b09fa54f1662d929

If there is any interest, I'd also happily open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant