Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some colors are wrong on neovim 0.10 #34

Open
lucc opened this issue May 21, 2024 · 3 comments
Open

Some colors are wrong on neovim 0.10 #34

lucc opened this issue May 21, 2024 · 3 comments

Comments

@lucc
Copy link

lucc commented May 21, 2024

With the release of neovim 0.10 the default colorscheme in neovim was changed. It seems that NeoSolarized picks up some of the default colors as some colors do not match the solarized theme when using neovim v0.10.

with neovim 0.10:

2024-05-21-121920_508x296_scrot

with neovim 0.9.5:

2024-05-21-122037_508x296_scrot

@xanderdunn
Copy link

Same problem here

@hasufell
Copy link

I switched to https://github.com/maxmx03/solarized.nvim

Then I had to adjust some settings to make it look the same:

vim.o.background = 'dark'

require('solarized').setup({
    transparent = false,
    palette = 'solarized',
    styles = {
      keywords = { bold = false },
    },
    highlights = {
      KeyWord = { fg = '#859900' },
      Delimiter = { fg = '#dc322f' },
      Number = { fg = '#2aa198' }
    },
})

vim.cmd.colorscheme 'solarized'

klappradla added a commit to klappradla/dotfiles that referenced this issue Sep 10, 2024
There's an incompatibility with Neovim v.0.10
(overcache/NeoSolarized#34) which makes some
colors no longer match the solarized theme.

Therefore (temporarily) switching to https://github.com/maxmx03/solarized.nvim
@Goorzhel
Copy link

neovim 0.10 changelog:

Default color scheme has been updated to be "Nvim branded" and accessible. [...] This also might result into some color schemes looking differently due to them relying on implicit assumptions about how highlight groups are defined by default. To account for this, define all attributes of highlight groups explicitly. Alternatively, use :colorscheme vim or :source $VIMRUNTIME/colors/vim.lua to restore previous definitions.

This sufficed for me:

@@ -134,6 +134,11 @@
 if exists("syntax_on")
   syntax reset
 endif
+if has('nvim-0.10')
+  " Pending explicit highlight-group definitions:
+  " https://github.com/overcache/NeoSolarized/issues/34
+  colorscheme vim
+endif
 let colors_name = "NeoSolarized"

 "}}}

I don't know enough about highlight groups—namely, which ones NeoSolarized left implicit—to pursue the correct fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants