-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
By overriding headers bundle must be added to 'test' environment to make tests work #19
Comments
It seems to me you've done the right thing, by design we've put graphiql only on I personally never had to add it to my tests, if you come up with a better idea I'm willing to take a look! |
Well, people usually don't need graphiql in their 'test' env, this is why I created this issue. Just because symfony finds an orphaned config it produces this error. There must be something to fix, may be documentation? |
I overrided templates/headers like it's described in the documentation to support XSRF tokens via DunglasAngularCsrfBundle in GraphiQL. Now, when I run behat tests I'm getting this error:
My config/packages/graphiql.yml looks like this:
To fix this issue I was forced to add 'test' to the list of envs of GraphiQLBundle. This is not a big deal just wanted to let you know may be there is some kind of a better solution for this? Add 'test' to envs by default? Or fix documentation, may be config/packages/dev/graphiql.yml is more correct place for config (not completely sure if it works this way).
And may be overriding a service, writing a class to override headers is better than overriding GraphiQL twig templates (I was forced to code a Twig extension just to put this XSRF token to overriden template)?
The text was updated successfully, but these errors were encountered: