Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is JDK8 module integrated into the main DSL module? #922

Open
lukaszlenart opened this issue Dec 22, 2020 · 1 comment
Open

Is JDK8 module integrated into the main DSL module? #922

lukaszlenart opened this issue Dec 22, 2020 · 1 comment

Comments

@lukaszlenart
Copy link

I'm trying to upgrade PhantomDSL to version 2.59.0 and I noticed that this version already contains package jdk8 (which the latest version is 2.42.0). So I assumed that I do not need the additional phantom-jdk8 module. Yet, after changing build.sbt to have just phantom-dsl in version 2.59.0 I got:

[error]           Cannot derive or find primitive implementation for class OffsetDateTime.
[error] Please create a Primitive manually using Primitive.iso or make sure
[error] the implicit Primitve for class OffsetDateTime is imported in the right scope.

On the official page you are still pointing out that to support JDK8 I need to use the phantom-jdk8 module
https://outworkers.github.io/phantom/basics/primitives.html#jdk8-primitives

So, what's the current status of supporting JDK8 by Phantom DSL?

@lukaszlenart
Copy link
Author

I noticed that you have changed the implicit for OffsetDateTime and now tuplePrimitive need to be manually provided, is this a right approach or bug?

  implicit def OffsetDateTimeIsPrimitive()(
    tuplePrimitive: Primitive[(Long, String)]
  ): Primitive[OffsetDateTime]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant