From 6c1f2ecbab3839b8a1f9c160ae4446eb837f4134 Mon Sep 17 00:00:00 2001
From: Thomas Coquelin <thomas.coquelin@numspot.com>
Date: Wed, 11 Oct 2023 18:37:24 +0200
Subject: [PATCH] Allow graceful inconsistency management by TF when public_ips
 in resourceOAPINatServiceRead() is empty

In `resourceOAPINatServiceRead()`, access to `public_ips[0]` isn't protected against empty list when the API can return an empty list in some edge cases.
When `public_ips` is empty, setting `public_ip_id` to `""` allows the TF refresh to succeed and the TF plan/apply to recreate the Nat Service with the correct `public_ip_id`.
---
 outscale/resource_outscale_nat_service.go | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/outscale/resource_outscale_nat_service.go b/outscale/resource_outscale_nat_service.go
index 8e0dc592c..bc105ff63 100644
--- a/outscale/resource_outscale_nat_service.go
+++ b/outscale/resource_outscale_nat_service.go
@@ -178,8 +178,14 @@ func resourceOAPINatServiceRead(d *schema.ResourceData, meta interface{}) error
 			return err
 		}
 
-		if err := set("public_ip_id", public_ips[0].GetPublicIpId()); err != nil {
-			return err
+		if len(public_ips) > 0 {
+			if err := set("public_ip_id", public_ips[0].GetPublicIpId()); err != nil {
+				return err
+			}
+		} else {
+			if err := set("public_ip_id", ""); err != nil {
+				return err
+			}
 		}
 
 		if err := d.Set("tags", tagsOSCAPIToMap(natService.GetTags())); err != nil {