fix: stop returning webhook secret hash of empty string

Signed-off-by: Donnie Adams <[email protected]>
otto8-ai · Nov 21, 2024 · e5fc89a · e5fc89a
1 parent 0eafa21
commit e5fc89a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/api/handlers/webhooks.go b/pkg/api/handlers/webhooks.go
@@ -149,7 +149,9 @@ func convertWebhook(webhook v1.Webhook, urlPrefix string) *types.Webhook {
 		HasToken:                   len(webhook.Spec.TokenHash) > 0,
 	}
 
-	wh.Secret = fmt.Sprintf("%x", sha256.Sum256([]byte(webhook.Spec.Secret)))
+	if webhook.Spec.Secret != "" {
+		wh.Secret = fmt.Sprintf("%x", sha256.Sum256([]byte(webhook.Spec.Secret)))
+	}
 
 	return wh
 }