Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong tag issue #57

Open
wengxt opened this issue Jun 9, 2017 · 2 comments
Open

Wrong tag issue #57

wengxt opened this issue Jun 9, 2017 · 2 comments

Comments

@wengxt
Copy link

wengxt commented Jun 9, 2017

I always carefully tag my music files, but I find slimpd tries to resolve the tag by itself based on certain unreliable source like file name. At I'm sure all of my music files have proper artist field in id3v2, but almost all my music in slimpd db is shown as unknown artists, certain ones that has artist is also wrong because there is a "-" in song title.

I tried to go through the config but not even clear config "artist-glue" helps (I do clear the cache and try hard-reset).

@othmar52
Copy link
Owner

othmar52 commented Jun 10, 2017

i found this snippet in my code

        if($this->conf["modules"]["enable_guessing"] == "1") {
            // do some voting for each attribute
            $this->runAttributeScoring();
        }

i think i have not implemented this configuration value properly but you can give it a try by configure:

[modules]
enable_guessing = 0

further you can try to hack core/php/Modules/Albummigrator/MigratorContext.php:78. you can replace the default scoring for real tag attributes (currently 2) with a very high value like 1000

// but add to recommendations in any case (higher scoring for real tag attributes)
$this->recommend([$setterName => $foundValue], 1000);

would be great if you can give feedback on that issue! in a few weeks i will continue my work on sliMpd

@wengxt
Copy link
Author

wengxt commented Jun 10, 2017

Ok, I found my issue is this kinds of guessing is done by post-processing of track. I tried to comment out everything in setTitle post processing so it solves some of my problem.

But still, slimpd seems to prefer use directory name as album name instead of the one from tag.

Also, the setArtist result seems to be correct, but the result in database are still wrong. I still get tones of unknown artist, and if I clicked into some artist from web page it shows totally wrong songs, I suspect there's also some bug in migration code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants