-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency on deprecated APIs #12
Comments
The url issue is something that you can fix yourself. Simply don't use something like
and instead use urls:
until chrome implements ontrack one has to use onaddstream. |
Got it, thanks! Would it be possible to conditionally use ontrack where available and otherwise fall back to onaddstream? |
https://github.com/webrtc/adapter lets you use ontrack even but that doesn't apply to the usage in this module. |
Well, just to clarify, I'm not actually using this package directly; my project includes SimpleWebRTC (as well as webrtc-adapter for the Edge polyfill), which in turn depends on RTCPeerConnection which depends on this. Would one of those packages be a better place to report this, or are they and traceablepeerconnection already handling this the best way possible until Chrome adds ontrack support? (Even after that happens, it seems to me that some conditional logic would be needed in at least one of these libraries to avoid breaking compatibility with older versions of Chrome.) |
In Firefox 52, I'm getting the console warnings
RTCIceServer.url is deprecated! Use urls instead.
for line 35 andonaddstream is deprecated! Use peerConnection.ontrack instead.
for line 53.The text was updated successfully, but these errors were encountered: