Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many tests fail in 2023.7 on s390x: _ostree_bootloader_zipl_post_bls_sync: assertion failed: (self->sysroot->booted_deployment) #3084

Closed
smcv opened this issue Oct 23, 2023 · 2 comments · Fixed by #3085
Closed

Many tests fail in 2023.7 on s390x: _ostree_bootloader_zipl_post_bls_sync: assertion failed: (self->sysroot->booted_deployment) #3084

smcv opened this issue Oct 23, 2023 · 2 comments · Fixed by #3085

Comments

@smcv
Copy link
Contributor

smcv commented Oct 23, 2023

Debian builds libostree in a chroot. In that environment, 25 tests fail with something similar to:

ERROR: tests/test-admin-upgrade-unconfigured.sh - Bail out! OSTree:ERROR:src/libostree/ostree-bootloader-zipl.c:387:_ostree_bootloader_zipl_post_bls_sync: assertion failed: (self->sysroot->booted_deployment)

Did #3059 perhaps not account for the fact that it's possible, and indeed likely during unit testing, that there should be no active boot loader at all?

cc @cgwalters
@smcv
Copy link
Contributor Author

smcv commented Oct 23, 2023 •
edited
Loading

Alternatively, do the tests (or libostree more generally) need to be skipping bootloader setup if !self->sysroot->booted_deployment?

cgwalters added a commit to cgwalters/ostree that referenced this issue Oct 24, 2023
@cgwalters
bootloader/zipl: No-op if run as non-root
75c7e51 
Closes: ostreedev#3084

Not the most elegant fix but should get the job done.
@cgwalters
Copy link
Member

This is on s390x right?

Did #3059 perhaps not account for the fact that it's possible, and indeed likely during unit testing, that there should be no active boot loader at all?

Yes, you're right.

@cgwalters cgwalters mentioned this issue Oct 24, 2023
Merged
raspbian-autopush pushed a commit to raspbian-packages/ostree that referenced this issue Nov 9, 2023
@cgwalters @smcv
bootloader/zipl: No-op if run as non-root
f463561 
Not the most elegant fix but should get the job done.

Bug: ostreedev/ostree#3084
Origin: upstream, 2023.8, commit:75c7e51a8bedb5edeadb9f54e84ccfff2adcc755

Gbp-Pq: Name bootloader-zipl-No-op-if-run-as-non-root.patch
raspbian-autopush pushed a commit to raspbian-packages/ostree that referenced this issue Nov 9, 2023
@cgwalters @smcv
bootloader/zipl: No-op if run as non-root
cbb1ba6 
Not the most elegant fix but should get the job done.

Bug: ostreedev/ostree#3084
Origin: upstream, 2023.8, commit:75c7e51a8bedb5edeadb9f54e84ccfff2adcc755

Gbp-Pq: Name bootloader-zipl-No-op-if-run-as-non-root.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bootloader/zipl: No-op if run as non-root cgwalters/ostree
2 participants
@cgwalters @smcv