Missing bootable label when encapsulating a commit

[cgwalters]

Trying to create an ostree container out of a commit, and the resulting image does not have a ostree.bootable label. When I try to import the container with ostree container unencapsulate I run into the error added in this commit: ostreedev/ostree-rs-ext@9c4a75b3778a3f2fdece095f8f5f7a6289ab512dLooks like the purpose of this condition was to identify ostree container images, but in my case the image did not get this label, and it is an ostree image. Is this a bug? Or am I misunderstanding?

[cgwalters]

As a workaround we've added the --label ostree.bootable=true argument to the encapsulate command and that seems to allow us to import our commit

[cgwalters]

Ohhh sorry! I misunderstood. Wait but...I only see the container store code processing this.

Precisely what commands are you running here? Are you sure it's ostree container unencapsulate that's failing?

ostree is absolutely intended to also support non-bootable things to be clear, but in practice...that's kind of our focus.

[javipolo]

I'm testing with the version:

[root@hub-2 ~]# ostree --version
libostree:
 Version: '2022.2'
 Git: a332611316fee36b1c630f8b266e4a37f77f2c54
 Features:
  - libcurl
  - libsoup
  - gpgme
  - libarchive
  - selinux
  - openssl
  - libmount
  - systemd
  - release
  - p2p

Expected way, without bootable label

On one host we create a commit, and with that an OCI container:

[root@hub-1 core]# ostree container encapsulate test registry:quay.io/javipolo/ostmagic:test --repo /ostree/repo                                                                                 
sha256:cb1394ced4b345b12c695f420bdd936ab94ec08e5f030d630c787a84a2d2f3c2

On another host we try to unencapsulate that:

[root@hub-2 ~]# ostree container unencapsulate --repo /ostree/repo ostree-unverified-registry:quay.io/javipolo/ostmagic:test                                                                     
   Downloading...                                                                                                                                                                             
error: Fetching manifest: Target image does not have ostree.bootable label

Adding the label as a workaround

However, if we add the ostree.bootable=true label, we can unencapsulate without problems:

[root@hub-1 core]# ostree container encapsulate test registry:quay.io/javipolo/ostmagic:test2 --repo /ostree/repo --label ostree.bootable=true                                                   
sha256:3314c030cc12f265cd768967b57644c746fb1288f50c1460da756229ef779126

[root@hub-2 ~]# ostree container unencapsulate --repo /ostree/repo ostree-unverified-registry:quay.io/javipolo/ostmagic:test2
   Downloading...                                                                                                                                                                              warning: Image is using v0 export layout, this is deprecated and support will be dropped in the future
Imported: ac1245f4abb9ff9f156bdf0559bbf05bd1ed8da43ad02b2ecb519eb89d9e9702

[omertuc]

I only see the container store code processing this

unencapsulate CLI calls container_import calls unencapsulate calls prepare_internal calls parse_manifest_layout which errors out

[cgwalters]

Yes, you're absolutely right. PR to fix this in ostreedev/ostree-rs-ext#513