Skip to content
This repository has been archived by the owner on Nov 7, 2024. It is now read-only.

deploy: Inherit previous kargs by default #502

Closed
cgwalters opened this issue Jul 19, 2023 · 0 comments · Fixed by #503
Closed

deploy: Inherit previous kargs by default #502

cgwalters opened this issue Jul 19, 2023 · 0 comments · Fixed by #503

Comments

@cgwalters
Copy link
Member

Today ostree container image deploy doesn't preserve previous deployment kargs, it only preserves booted:

override_kernel_argv: options.kargs,

This is a huge ergonomic problem for coreos/fedora-coreos-tracker#1151 (comment)

cgwalters added a commit to cgwalters/ostree-rs-ext that referenced this issue Jul 19, 2023
This is the same bug as
ostreedev@3089166
but for the not-booted case.

Basically in the C API bridged to Rust we can't distinguish between
"NULL array" and "zero length array".  But the _with_options path
supports distinguishing them, and we want the "no kargs provided"
case to not override anything.

Closes: ostreedev#502
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant