New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_rrddata() should be inside ProxtopCollector() class and take fewer args #7

Open

wdoekes opened this issue May 15, 2017 · 0 comments

Labels

Member

wdoekes commented May 15, 2017

Splitting up get_rrdata into smaller functions is a good start.

Secondly, using setters like 'set_timeframe()' on the Collector lets us pass fewer arguments to the get_rrdata() function directly.

wdoekes added the SpringCleaning label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment