Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should the TAC handle overdue PR decisions? #405

Open
marcelamelara opened this issue Oct 25, 2024 · 3 comments
Open

How should the TAC handle overdue PR decisions? #405

marcelamelara opened this issue Oct 25, 2024 · 3 comments

Comments

@marcelamelara
Copy link
Contributor

marcelamelara commented Oct 25, 2024

While the TAC has a documented decision process for open PRs,...

...this document doesn't address is what we do in case the waiting period ends and we still don't have enough approvals. I'm not sure there is really a solution to this though, other than not re-electing TAC members who are failing to respond in a timely manner...

Originally posted by @lehors in #402 (review)

@sevansdell
Copy link
Contributor

If we want to make that official (TAC members not eligible for re-election if not participating in closing PRs in timeline) we would need to make that language official in the TAC election documentation for eligibility. We could also put a statement in the TAC member R&R that failure to do these duties may result in ineligibility to run for re-election.

@lehors
Copy link
Contributor

lehors commented Nov 2, 2024

I know I raised that question but I am not sure we should really do anything about it. I think my point about leaving it to the electors is actually sensible. This is no different from how it works for elected officials in our government for instance.

@marcelamelara
Copy link
Contributor Author

I think my point about leaving it to the electors is actually sensible. This is no different from how it works for elected officials in our government for instance.

I generally agree with this. And at the same time, I also don't get the sense that most electors outside TI leads are watching the TAC's activities. To me, the issues is less about delays and more about irregular active participation in PR reviews.

I would be ok with adding some text into the TAC member R&Rs to say that the if a TAC member fails to respond consistently, even after check-ins from the TAC chair/other members, then that person could become ineligible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants