PostgreSQL 17 support

[devrimgunduz]

Hi,

pg_bulkload fails to build against PostgreSQL 17. Logs are below. v17 beta2 is already out. Can you please take a look?

Thanks, Devrim

/usr/bin/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -Wno-format-truncation -O2 -I../include -I/usr/pgsql-17/include -I. -I./ -I/usr/pgsql-17/include/server -I/usr/pgsql-17/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 -DWITH_GZFILEOP -I/usr/include -flto=thin -emit-llvm -c -o pgut/pgut-list.bc pgut/pgut-list.c
In file included from pgut/pgut-list.c:13:
In file included from pgut/pgut-list.h:13:
In file included from /usr/pgsql-17/include/server/nodes/pg_list.h:42:
/usr/pgsql-17/include/server/nodes/nodes.h:149:20: error: call to undeclared function 'palloc0'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
149 | result = (Node *) palloc0(size);
| ^
/usr/pgsql-17/include/server/nodes/nodes.h:149:11: warning: cast to 'Node *' (aka 'struct Node *') from smaller integer type 'int' [-Wint-to-pointer-cast]
149 | result = (Node *) palloc0(size);
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from pgut/pgut-list.c:14:
In file included from /usr/pgsql-17/include/server/postgres_fe.h:27:
/usr/pgsql-17/include/server/common/fe_memutils.h:58:14: error: conflicting types for 'palloc0'
58 | extern void *palloc0(Size size);
| ^
/usr/pgsql-17/include/server/nodes/nodes.h:149:20: note: previous implicit declaration is here
149 | result = (Node *) palloc0(size);
| ^
1 warning and 2 errors generated.
make[2]: *** [/usr/pgsql-17/lib/pgxs/src/makefiles/../../src/Makefile.global:1085: pgut/pgut-list.bc] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from pg_bulkload.c:18:
In file included from ./pgut/pgut-list.h:13:
In file included from /usr/pgsql-17/include/server/nodes/pg_list.h:42:
/usr/pgsql-17/include/server/nodes/nodes.h:149:20: error: call to undeclared function 'palloc0'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
149 | result = (Node *) palloc0(size);
| ^
/usr/pgsql-17/include/server/nodes/nodes.h:149:11: warning: cast to 'Node *' (aka 'struct Node *') from smaller integer type 'int' [-Wint-to-pointer-cast]
149 | result = (Node *) palloc0(size);
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/pgsql-17/include/server/nodes/pg_list.h:42,
from pgut/pgut-list.h:13,
from pgut/pgut-list.c:13:
/usr/pgsql-17/include/server/nodes/nodes.h: In function ‘newNode’:
/usr/pgsql-17/include/server/nodes/nodes.h:149:27: error: implicit declaration of function ‘palloc0’; did you mean ‘valloc’? [-Wimplicit-function-declaration]
149 | result = (Node *) palloc0(size);
| ^~~~~~~
| valloc
/usr/pgsql-17/include/server/nodes/nodes.h:149:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
149 | result = (Node *) palloc0(size);
| ^
In file included from /usr/pgsql-17/include/server/postgres_fe.h:27,
from pgut/pgut-list.c:14:
/usr/pgsql-17/include/server/common/fe_memutils.h: At top level:
/usr/pgsql-17/include/server/common/fe_memutils.h:58:14: error: conflicting types for ‘palloc0’; have ‘void *(Size)’ {aka ‘void *(long unsigned int)’}
58 | extern void *palloc0(Size size);
| ^~~~~~~
/usr/pgsql-17/include/server/nodes/nodes.h:149:27: note: previous implicit declaration of ‘palloc0’ with type ‘int()’
149 | result = (Node *) palloc0(size);
| ^~~~~~~
1 warning and 1 error generated.
make[2]: *** [: pgut/pgut-list.o] Error 1
In file included from /usr/pgsql-17/include/server/nodes/pg_list.h:42,
from pgut/pgut-list.h:13,
from pg_bulkload.c:18:
/usr/pgsql-17/include/server/nodes/nodes.h: In function ‘newNode’:
/usr/pgsql-17/include/server/nodes/nodes.h:149:27: error: implicit declaration of function ‘palloc0’; did you mean ‘valloc’? [-Wimplicit-function-declaration]
149 | result = (Node *) palloc0(size);
| ^~~~~~~
| valloc
/usr/pgsql-17/include/server/nodes/nodes.h:149:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
149 | result = (Node *) palloc0(size);
| ^
make[2]: *** [: pg_bulkload.o] Error 1
make[2]: *** [/usr/pgsql-17/lib/pgxs/src/makefiles/../../src/Makefile.global:1085: pg_bulkload.bc] Error 1

[devrimgunduz]

ping

[devrimgunduz]

ping

[devrimgunduz]

ping . GA is getting really close.