Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Allow title to end with (#N) #25

Open
luabida opened this issue Jan 23, 2023 · 2 comments
Open

[Bugfix] Allow title to end with (#N) #25

luabida opened this issue Jan 23, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@luabida
Copy link
Collaborator

luabida commented Jan 23, 2023

When the PR is merged, git's default squash title ends with the merge enumeration, but the action is not accepting this syntax.
@luabida luabida added the bug Something isn't working label Jan 23, 2023
@luabida
Copy link
Collaborator Author

luabida commented Jan 23, 2023

example:
fix(semantic-release): pin node version on npx (#16)
Output:
❌ PR Title check failed

@xmnlab
Copy link
Member

xmnlab commented Feb 29, 2024

that is totally fine .. it should accept that the PR id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xmnlab @luabida