Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter: Improve mypy configuration #116

Open
xmnlab opened this issue Sep 27, 2024 · 3 comments
Open

linter: Improve mypy configuration #116

xmnlab opened this issue Sep 27, 2024 · 3 comments
Labels
psf-grant-proposal Issues used for a PSF grant proposal

Comments

@xmnlab
Copy link
Member

xmnlab commented Sep 27, 2024

Currently, mypy is not very well configured.

This is the new configuration proposed:

[tool.mypy]
python_version = "3.8"
check_untyped_defs = true
strict = true
ignore_missing_imports = true
warn_unused_ignores = true
warn_redundant_casts = true
warn_unused_configs = true
show_error_codes = true
exclude = ["scripts/"]
@xmnlab
Copy link
Member Author

xmnlab commented Sep 27, 2024

@abhijeetSaroha could you work on that? if so, I can add here the label for the psf grant.

after this change maybe a bunch of changes in the annotations would be necessary.

@abhijeetSaroha
Copy link
Collaborator

Sure, I'd be happy to work on this!

Could you provide more details on the specific areas you're looking to improve with this change? Also, any specific scripts or modules where these annotations may need updates would be helpful to know in advance.

@xmnlab xmnlab added the psf-grant-proposal Issues used for a PSF grant proposal label Sep 27, 2024
@xmnlab
Copy link
Member Author

xmnlab commented Sep 27, 2024

mypy is used as a tool for checking type annotation .. the current configuration is not good ... it is very fragile .. so if this new configuration it will be more strict ..

I am doing the same for sugar: https://github.com/osl-incubator/sugar/pull/125/files
but I am changing more things there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
psf-grant-proposal Issues used for a PSF grant proposal
Projects
None yet
Development

No branches or pull requests

2 participants