Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download option for "facts" #7

Open
abetusk opened this issue Nov 9, 2020 · 0 comments
Open

Add download option for "facts" #7

abetusk opened this issue Nov 9, 2020 · 0 comments

Comments

@abetusk
Copy link
Contributor

abetusk commented Nov 9, 2020

Provide a download option for the "facts" graphic, preferably with options for SVG, PNG and JPEG.

Here is a graphic sample:

facts_download_preview

abetusk added a commit to abetusk/certification-mark-generator that referenced this issue Nov 9, 2020
* initially 'click' the go button (js call)
* add download option with radio buttons to select option for graphic type
  to download
* minimal javascript infrastructure to allow for different download
  options and size options (not user facing but there for the future if
  need be).
jywarren added a commit that referenced this issue May 30, 2021
* Resolves issue #7, #8

* initially 'click' the go button (js call)
* add download option with radio buttons to select option for graphic type
  to download
* minimal javascript infrastructure to allow for different download
  options and size options (not user facing but there for the future if
  need be).

* adding certification template

* index.svg was giving problems when rendering. This svg allows for
  a preview image

* Resolves issue #9, cleaning up README

Making README more readable as per issue #9

* Adding image link to 'facts' section

* Finally getting markdown image link right

* Markdown image link for certification

* bug fix, downloads jpg

* border pixel pix (jpg,png)

* Downloading the 'facts' graphic (png,jpg), the border pixel was getting
  cutoff becaues, I think, the width/height were non-integral
* To fix, round up to nearest integer for width and height

Co-authored-by: Jeffrey Warren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant