Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin.php and themes.php #5

Open
Nikoya opened this issue Nov 8, 2013 · 3 comments
Open

Add admin.php and themes.php #5

Nikoya opened this issue Nov 8, 2013 · 3 comments

Comments

@Nikoya
Copy link
Contributor

Nikoya commented Nov 8, 2013

It can be great to enable this plugin on admin.php and themes.php too (actually limit to post-new.php and post.php)

Cause some settings page can use visual editor so it it's logic to use EBs in it too.

If you are ok i can push it.

Thx

@swashata
Copy link
Contributor

swashata commented Nov 8, 2013

+1 for this. Although I think it would be better to use mce_external_plugins and mce_buttons to to include the script and buttons instead of admin.php and themes.php. This way the shortcode buttons will be enqueued whenever wp_editor with visual editor support is called.

@Nikoya
Copy link
Contributor Author

Nikoya commented Nov 8, 2013

Totally true.
Your idea is better :)

@oscitasthemes
Copy link
Owner

Hi, I think if we remove the condition of post.php and post-new.php, then it will solve our problem. what say?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants