Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of Singular kernel errors in libsingular #671

Open
fingolfin opened this issue Jun 15, 2023 · 0 comments
Open

Fix handling of Singular kernel errors in libsingular #671

fingolfin opened this issue Jun 15, 2023 · 0 comments
Labels

Comments

@fingolfin
Copy link
Member

The way we handle kernel errors in our C++ wrapper code is wrong. As a result, all kinds of things can break. Part of the problem is this:

static void WerrorS_and_reset(const char * s)
{
    errorreported = 0;
...

We reset the error flag in our Singular kernel error callback. But that can lead to the Singular kernel next executing things it normally wouldn't have executed, because it is no longer aware that something just went wrong!

So we must reset this flag elsewhere, later.

One strategy would be to just reset it at the end of every wrapper function.... Not nice but I can't think of anything much better right now :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant