Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finite fields are not subtypes of AbstractAlgebra.FinField #280

Open
rfourquet opened this issue Oct 13, 2020 · 1 comment
Open

Finite fields are not subtypes of AbstractAlgebra.FinField #280

rfourquet opened this issue Oct 13, 2020 · 1 comment

Comments

@rfourquet
Copy link
Contributor

This prevents using Singular finite fields in methods expecting a finite field (e.g. rand defined in Nemo).

Currently, there is

abstract type Field <: AbstractAlgebra.Field end

Should we have

abstract type FinField <: AbstractAlgebra.FinField end
const SingularField = Union{Field,FinField} # or SField, or ...

and then use SingularField instead of Field when appropriate?

@wbhart
Copy link
Contributor

wbhart commented Oct 13, 2020

You'll find this problem everywhere in Singular due to the lack of multiple inheritance. If you can come up with something better that still passes the tests, go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants