-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Banners #92
Comments
It's worth adding that we have been removing banners where this is actually desirable (e.g. non-interactive/library use), but that this has been technically very difficult. We apologise to everyone who has been affected by this. The issue is being addressed as we are able. |
Hi, so is there a way to disable showing the banner by default when using Oscar as a dependency in a project? In out code, we have not just Oscar but all of its dependecies showing banners as well. It would be nice to have unified way to disable the display by default (i.e. an |
If Oscar is a dependency of something else, then I agree that at most it should show its banner, but not the dependencies. That this is not currently the case is a bug! Here's what e.g. if haskey(ENV, "GAP_SHOW_BANNER")
show_banner = ENV["GAP_SHOW_BANNER"] == "true"
else
show_banner =
isinteractive() && !any(x -> x.name in ["Oscar"], keys(Base.package_locks))
end The use of the (undocumented) Note that for GAP.jl and also |
We don't have it in Hecke yet, but after talking to @fieker, |
I meant Nemo.jl, not Hecke.jl, my bad. |
@fingolfin I put this line at the top of my module like so: module MyModule
ENV["NEMO_PRINT_BANNER"] = "false" and it still prints the banner. Is it such placement correct? |
It is too late. The banner is printed before this line is reached. |
If it is only about your use, you can add the following line to ENV["NEMO_PRINT_BANNER"] = false |
Not sure this is the right place for such a discussion but Some attempts starting with the current Oscar banner.
|
I absolutely agree with (the first part of) Nemocas/AbstractAlgebra.jl#158 (comment) and think no message should be displayed at all. |
The issue of banners for your projects comes up about every 6 months. So we, the project leaders, discussed it and recording this here, as an issue to be able to link against this.
Computer Algebra Systems always have banners
Thus our "cornerstones" have banners - which can be suppressed in non-interactive mode.
Now we added a new, interactive, user interface to our systems, so of course, we display banners on interactive use - and do not print them otherwise. In Oscar, we "accumulate" the individual banners into the Oscar one.
Hecke/ Nemo are intended also as computer algebra systems, not "only" as libraries, thus have banners - which are not shown unless we are interactive.
The text was updated successfully, but these errors were encountered: