remove an intersect method
#4285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method is applicable to a vector whose type can be constructed only by explicitly prescribing it. Having an `intersect` method for this case looks strange. (And logically, `intersect` for one vector contradicts Julia's default behaviour, which just returns this vector.)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4285 +/- ##
==========================================
+ Coverage 84.49% 84.51% +0.01%
==========================================
Files 641 641
Lines 85476 85465 -11
==========================================
+ Hits 72226 72228 +2
+ Misses 13250 13237 -13
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is applicable to a vector whose type can be constructed only by explicitly prescribing it.
Having an
intersectmethod for this case looks strange.(And logically,
intersectfor one vector contradicts Julia's default behaviour, which just returns this vector.)