Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task csv-to-oscal-cd should allow for comment columns #1458

Closed
degenaro opened this issue Oct 2, 2023 · 1 comment
Closed

task csv-to-oscal-cd should allow for comment columns #1458

degenaro opened this issue Oct 2, 2023 · 1 comment
Assignees

Comments

@degenaro
Copy link
Collaborator

degenaro commented Oct 2, 2023

Issue description / feature objectives

Presently, the task csv-to-ocsal cd attempts to include all unadorned columns as properties in the transformation from csv to OSCAL json.

A new feature: when the column name starts with a # the column should be ignored; that is the column data will not be included in the produced json. This will facilitate inclusion of data that is desired in the csv but is not desired in the resulting json.

Caveats / Assumptions

The reverse process from comp-def to csv, should it ever come into existence, would not be able to reconstitute the original csv in its entirety, since the data in the # column will not be present.

Completion Criteria

Help and test cases updated.

@degenaro degenaro self-assigned this Oct 2, 2023
@degenaro
Copy link
Collaborator Author

degenaro commented Oct 4, 2023

Fixed by #1459

@degenaro degenaro closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant