-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Decouple Python version and Go version #22
Comments
@yana1205 Is this issue something I can assist with or work on? |
Thanks @jpower432,
|
Hi @yana1205. Thanks for sharing your thoughts on the approach. I added some notes and questions below. Forking makes sense to me to preserve the Git history. The name I'm curious about the rationale for using a Git submodule in the original repository. Is the backward compatibility requirement due to users installing the Go module directly from this location, or are there downstream tools relying on the current repository structure with the |
@jpower432 |
Thanks for the context @yana1205. It sounds like we are aligned on an approach. I will get to work on creating the fork.
|
Step 1 Complete - https://github.com/oscal-compass/compliance-to-policy-go |
Thanks! |
@yana1205 I am still working to get this fully completed. I requested that |
If I remember correctly, I wasn’t able to fork this repository when I opened a PR. Instead, I cloned it and pushed it to my account. Now I can fork this repository. It seems like keeping it detached is necessary so that people who have already forked c2p can also fork c2p-go. Thanks for the information. |
Issue description / feature objectives
C2P has supported Python and Go. For Go, it's maintained under sub-directory (/go) and the Go module is referenced as
github.com/oscal-compass/compliance-to-policy/go
. It's better to separate the Go version in a different repository for maintainability.(This is feedback from Raised by George Vauter (@gvauter ). Thank you for your feedback.)
Caveats / Assumptions
No response
Completion Criteria
Separate the Go version in a different repository
Related links
slack: https://cloud-native.slack.com/archives/C06F3PEPNBW/p1717786627638569?thread_ts=1717786588.204509&cid=C06F3PEPNBW
The text was updated successfully, but these errors were encountered: