From 837241fb8f487e47a53c401857527a49c93f46f6 Mon Sep 17 00:00:00 2001 From: Jennifer Power Date: Tue, 27 Aug 2024 15:50:07 -0400 Subject: [PATCH] docs: rewords section about CODEOWNERS in MEMBERSHIP.md We want maintainer approval to merge PRs, but not restrict the ability to merge PRs with the proper approvals Signed-off-by: Jennifer Power --- MEMBERSHIP.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MEMBERSHIP.md b/MEMBERSHIP.md index 9e76a39..1c8cd0c 100644 --- a/MEMBERSHIP.md +++ b/MEMBERSHIP.md @@ -24,7 +24,7 @@ The following table provides information about the current roles available to th | Reviewer | Write with merging restricted via CODEOWNERS | | Maintainer | Maintain | -> Note: Each project will require push restriction branch protection rule to allow only CODEOWNERS to push to default branches. +> Note: Each project will require branch protection rule to require CODEOWNER approval for PRs to default branches. It GitHub this would mean setting the `Require review from Code Owners`. ### Member @@ -84,7 +84,7 @@ Any person who meets the requirements may be nominated by a contributor, includi As a project Reviewer, you have the following responsibilities and privileges: -* You have the permission to approve, but not merge, a PR. +* You have the permission to approve and merge a PR with CODEOWNER approval * You have permission to label issues and PRs. * You consistently assign, close, and reopen issues or PRs. * You actively triage issues and PRs with high quality.